[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Call for testing

From: Thomas Preud'homme
Subject: Re: [Tinycc-devel] Call for testing
Date: Mon, 14 Jan 2013 17:26:54 +0100
User-agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )

Le dimanche 6 janvier 2013 17:03:28, grischka a écrit :
> Other candidates for reversion (OTOH):
> -
> http://repo.or.cz/w/tinycc.git/commitdiff/fc574f14984d11f1ead50560d1bdc5ae
> 0eaf6d8d The headers from include are copied to win32/include during
> install

I'm not sure to understand why _STATIC_ASSERT was modified. Are you just 
claiming the fix is subobptimal because of the code duplication or the fix is 

> -
> http://repo.or.cz/w/tinycc.git/commitdiff/943574aba54713ca4a17fe33aadde5ab
> ee233b53 Obviously (if you look at the code) this was not a bug but
> intended behavior.

Indeed. I followed the chain of changes when I noticed that patch and it led 
to your commit f366cb20fe06396609a5438756c3c49662b7316c. However, I didn't 
read into details the content of the for loops at that time. I just assumed a 
bug was noticed by someone and that was the fix. Now, I see the "if (0 == *p)" 
and realize it was indeed intentional. Reverted.

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]