[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Simulavr-devel] ATMega8 class definition
From: |
Petr Hluzín |
Subject: |
Re: [Simulavr-devel] ATMega8 class definition |
Date: |
Sun, 17 Oct 2010 21:35:43 +0200 |
Hello
On 15 October 2010 21:30, Petr Hluzín <address@hidden> wrote:
> I will commit the fix and review your new files tomorrow (in Europe),
> unless an other commiter is faster.
Fix committed [1]. I think there were some problems [2], verify if my
fix is correct.
The Atmega8 code leaves some registers as not implemented yet and some
are reserved by Atmel. I would prefer to distinguish these cases.
However the code in master branch has some issues (leaks "invalidRW"
instances, although fixed in my code/branch), this has to be decided
and tackled first. For now I leave it as is.
[1]
http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=801ccf82023e03ff15a52d6a9378d689da297f20
[2]
http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=1f61f8a99f10248146cfd8c52215981358df7bd4
--
Petr Hluzin