Re: [Quilt-dev] Quilt 0.64 coming soon

[Jean Delvare]

Hi Yoshi,

Le Friday 06 February 2015 à 08:45 +0900, Yasushi SHOJI a écrit :
> Hi Jean,
> 
> At Thu, 05 Feb 2015 17:52:22 +0100,
> Jean Delvare wrote:
> > 
> > Le Thursday 05 February 2015 à 23:30 +0900, Yasushi SHOJI a écrit :
> > > Jean,
> > > 
> > > At Thu, 05 Feb 2015 10:39:04 +0100,
> > > Jean Delvare wrote:
> > > > 
> > > > I've pulled that, thank you very much. However I think one translated
> > > > string will not produce the right result:
> > > > 
> > > > #: quilt/scripts/patchfns.in:1018
> > > > msgid "You have to install '%s' (from package %s) to use 'quilt %s'\\n"
> > > > msgstr ""
> > > > "'quilt %s' を使用するためには、(パッケージ %sから) '%s' をインストール\n"
> > > > "する必要があります\\n"
> > > 
> > > Ah, I forgot to fix that.  Thank you for catching this.
> 
> BTW, would you mind if i ask how you find this argument order bug?

Patch review. Even though I can't read Japanese, I still did a quick
review of your patch to check for things like missing or extra newlines,
backslashes etc.

> > > This is the best I've came up with:
> > >   msgstr "'%s' (%s パッケージ) がインストールされていないと、'quilt %s' は利用できません\\n"
> > > 
> > > I've updated my repo (non-ff) so please pull it again. 
> > > 
> > > https://github.com/yashi/quilt.git tags/ja.po-update-for-0.64
> > 
> > As far as I can see, the tag still points at the old commit (although it
> > no longer exists... odd.) Anyway I had already merged and pushed your
> > initial translation so I expected an incremental update. The git server
> > on savannah won't let me overwrite the previous commit anyway, so an
> > incremental commit is the only way to go at this point.
> 
> sorry for the confusion. will do incremental updates next time.
> (or post a review first)

Yes, I think it is better.

> > So I made a diff between the old version and the new version and
> > committed that as an additional commit.
> 
> Thank you for all the work and those additional works I caused.  Quilt
> passes all the test on my system and looks great to me.

No problem, and thanks again for the translation and the testing, this
is very appreciated.

-- 
Jean Delvare
SUSE L3 Support