Re: [Qemu-ppc] [PATCH v4 03/20] ppc/pnv: add a core mask to PnvChip

[David Gibson]

On Mon, Oct 10, 2016 at 02:56:25PM +0200, Cédric Le Goater wrote:
> 
> >> @@ -227,11 +227,44 @@ static void ppc_powernv_init(MachineState *machine)
> >>          snprintf(chip_name, sizeof(chip_name), "chip[%d]", CHIP_HWID(i));
> >>          object_property_add_child(OBJECT(pnv), chip_name, chip, 
> >> &error_fatal);
> >>          object_property_set_int(chip, CHIP_HWID(i), "chip-id", 
> >> &error_fatal);
> >> +        object_property_set_int(chip, smp_cores, "nr-cores", 
> >> &error_fatal);
> >> +        /*
> >> +         * We could customize cores_mask for the chip here. May be
> >> +         * using a powernv machine property, like 'num-chips'. Let the
> >> +         * chip choose the default for now.
> > 
> > I don't think you need any special mechanism for this.  If you just
> > remove this explicit assignment the chip default will apply, but the
> > user can alter it using -global.
> 
> Using a command line with :
> 
>       -global powernv-chip-POWER8.cores-mask=0x7070
> 
> would work for one chip but not for more. Let's start with that, I will 
> remove the comment for now. multiple chip is for later.

Well, it works for more than one chip if you want the same mask for
each of them.  If you want different masks, I think you can still do
it with -set, but working out the right arguments can be a PITA.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature