[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/13] apic: disable reentrancy detection for apic-msi
From: |
Thomas Huth |
Subject: |
[PULL 13/13] apic: disable reentrancy detection for apic-msi |
Date: |
Fri, 28 Apr 2023 11:43:46 +0200 |
From: Alexander Bulekov <alxndr@bu.edu>
As the code is designed for re-entrant calls to apic-msi, mark apic-msi
as reentrancy-safe.
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Message-Id: <20230427211013.2994127-9-alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/intc/apic.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index 20b5a94073..ac3d47d231 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@ -885,6 +885,13 @@ static void apic_realize(DeviceState *dev, Error **errp)
memory_region_init_io(&s->io_memory, OBJECT(s), &apic_io_ops, s,
"apic-msi",
APIC_SPACE_SIZE);
+ /*
+ * apic-msi's apic_mem_write can call into ioapic_eoi_broadcast, which can
+ * write back to apic-msi. As such mark the apic-msi region re-entrancy
+ * safe.
+ */
+ s->io_memory.disable_reentrancy_guard = true;
+
s->timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, apic_timer, s);
local_apics[s->id] = s;
--
2.31.1
- [PULL 00/13] DMA reentrancy fixes and other misc patches, Thomas Huth, 2023/04/28
- [PULL 01/13] s390x/gdb: Split s390-virt.xml, Thomas Huth, 2023/04/28
- [PULL 03/13] hw/rdma: Compile target-independent parts of the rdma code only once, Thomas Huth, 2023/04/28
- [PULL 06/13] memory: prevent dma-reentracy issues, Thomas Huth, 2023/04/28
- [PULL 05/13] tests: vhost-user-test: release mutex on protocol violation, Thomas Huth, 2023/04/28
- [PULL 07/13] async: Add an optional reentrancy guard to the BH API, Thomas Huth, 2023/04/28
- [PULL 04/13] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI, Thomas Huth, 2023/04/28
- [PULL 02/13] hw/rdma: Remove unused macros PG_DIR_SZ and PG_TBL_SZ, Thomas Huth, 2023/04/28
- [PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks, Thomas Huth, 2023/04/28
- [PULL 09/13] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded, Thomas Huth, 2023/04/28
- [PULL 13/13] apic: disable reentrancy detection for apic-msi,
Thomas Huth <=
- [PULL 12/13] raven: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- [PULL 10/13] lsi53c895a: disable reentrancy detection for script RAM, Thomas Huth, 2023/04/28
- [PULL 11/13] bcm2835_property: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- Re: [PULL 00/13] DMA reentrancy fixes and other misc patches, Richard Henderson, 2023/04/28