[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks
From: |
Thomas Huth |
Subject: |
[PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks |
Date: |
Fri, 28 Apr 2023 11:43:41 +0200 |
From: Alexander Bulekov <alxndr@bu.edu>
Advise authors to use the _guarded versions of the APIs, instead.
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Message-Id: <20230427211013.2994127-4-alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/checkpatch.pl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d768171dcf..eeaec436eb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2865,6 +2865,14 @@ sub process {
if ($line =~ /\bsignal\s*\(/ && !($line =~ /SIG_(?:IGN|DFL)/)) {
ERROR("use sigaction to establish signal handlers;
signal is not portable\n" . $herecurr);
}
+# recommend qemu_bh_new_guarded instead of qemu_bh_new
+ if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\bqemu_bh_new\s*\(/) {
+ ERROR("use qemu_bh_new_guarded() instead of
qemu_bh_new() to avoid reentrancy problems\n" . $herecurr);
+ }
+# recommend aio_bh_new_guarded instead of aio_bh_new
+ if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\baio_bh_new\s*\(/) {
+ ERROR("use aio_bh_new_guarded() instead of aio_bh_new()
to avoid reentrancy problems\n" . $herecurr);
+ }
# check for module_init(), use category-specific init macros explicitly please
if ($line =~ /^module_init\s*\(/) {
ERROR("please use block_init(), type_init() etc.
instead of module_init()\n" . $herecurr);
--
2.31.1
- [PULL 00/13] DMA reentrancy fixes and other misc patches, Thomas Huth, 2023/04/28
- [PULL 01/13] s390x/gdb: Split s390-virt.xml, Thomas Huth, 2023/04/28
- [PULL 03/13] hw/rdma: Compile target-independent parts of the rdma code only once, Thomas Huth, 2023/04/28
- [PULL 06/13] memory: prevent dma-reentracy issues, Thomas Huth, 2023/04/28
- [PULL 05/13] tests: vhost-user-test: release mutex on protocol violation, Thomas Huth, 2023/04/28
- [PULL 07/13] async: Add an optional reentrancy guard to the BH API, Thomas Huth, 2023/04/28
- [PULL 04/13] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI, Thomas Huth, 2023/04/28
- [PULL 02/13] hw/rdma: Remove unused macros PG_DIR_SZ and PG_TBL_SZ, Thomas Huth, 2023/04/28
- [PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks,
Thomas Huth <=
- [PULL 09/13] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded, Thomas Huth, 2023/04/28
- [PULL 13/13] apic: disable reentrancy detection for apic-msi, Thomas Huth, 2023/04/28
- [PULL 12/13] raven: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- [PULL 10/13] lsi53c895a: disable reentrancy detection for script RAM, Thomas Huth, 2023/04/28
- [PULL 11/13] bcm2835_property: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- Re: [PULL 00/13] DMA reentrancy fixes and other misc patches, Richard Henderson, 2023/04/28