[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/13] tests: vhost-user-test: release mutex on protocol violation
From: |
Thomas Huth |
Subject: |
[PULL 05/13] tests: vhost-user-test: release mutex on protocol violation |
Date: |
Fri, 28 Apr 2023 11:43:38 +0200 |
From: Paolo Bonzini <pbonzini@redhat.com>
chr_read() is printing an error message and returning with s->data_mutex taken.
This can potentially cause a hang. Reported by Coverity.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20230427125423.103536-1-pbonzini@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/vhost-user-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index bf9f7c4248..e4f95b2858 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -351,7 +351,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
if (size != msg.size) {
qos_printf("%s: Wrong message size received %d != %d\n",
__func__, size, msg.size);
- return;
+ goto out;
}
}
@@ -509,6 +509,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
break;
}
+out:
g_mutex_unlock(&s->data_mutex);
}
--
2.31.1
- [PULL 00/13] DMA reentrancy fixes and other misc patches, Thomas Huth, 2023/04/28
- [PULL 01/13] s390x/gdb: Split s390-virt.xml, Thomas Huth, 2023/04/28
- [PULL 03/13] hw/rdma: Compile target-independent parts of the rdma code only once, Thomas Huth, 2023/04/28
- [PULL 06/13] memory: prevent dma-reentracy issues, Thomas Huth, 2023/04/28
- [PULL 05/13] tests: vhost-user-test: release mutex on protocol violation,
Thomas Huth <=
- [PULL 07/13] async: Add an optional reentrancy guard to the BH API, Thomas Huth, 2023/04/28
- [PULL 04/13] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI, Thomas Huth, 2023/04/28
- [PULL 02/13] hw/rdma: Remove unused macros PG_DIR_SZ and PG_TBL_SZ, Thomas Huth, 2023/04/28
- [PULL 08/13] checkpatch: add qemu_bh_new/aio_bh_new checks, Thomas Huth, 2023/04/28
- [PULL 09/13] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded, Thomas Huth, 2023/04/28
- [PULL 13/13] apic: disable reentrancy detection for apic-msi, Thomas Huth, 2023/04/28
- [PULL 12/13] raven: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- [PULL 10/13] lsi53c895a: disable reentrancy detection for script RAM, Thomas Huth, 2023/04/28
- [PULL 11/13] bcm2835_property: disable reentrancy detection for iomem, Thomas Huth, 2023/04/28
- Re: [PULL 00/13] DMA reentrancy fixes and other misc patches, Richard Henderson, 2023/04/28