Re: [PATCH 05/12] tcg/mips: Split out tcg_out_movi_one

[Richard Henderson]

On 4/11/23 14:34, Philippe Mathieu-Daudé wrote:
> > +    if (tcg_out_movi_one(s, ret, arg)) {
> >           return;
> >       }
> > +
> >       if (TCG_TARGET_REG_BITS == 32 || arg == (int32_t)arg) {
> >           tcg_out_opc_imm(s, OPC_LUI, ret, TCG_REG_ZERO, arg >> 16);
>
> Shouldn't this block be removed in this patch?

No, because it feeds into the lui+ori path.
It gets cleaned up in the next patch.


r~