[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/12] tcg/mips: Aggressively use the constant pool for n64 calls
From: |
Richard Henderson |
Subject: |
[PATCH 08/12] tcg/mips: Aggressively use the constant pool for n64 calls |
Date: |
Fri, 7 Apr 2023 20:03:55 -0700 |
Repeated calls to a single helper are common -- especially
the ones for softmmu memory access. Prefer the constant pool
to longer sequences to increase sharing.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/mips/tcg-target.c.inc | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/tcg/mips/tcg-target.c.inc b/tcg/mips/tcg-target.c.inc
index 235295c689..e37aca5986 100644
--- a/tcg/mips/tcg-target.c.inc
+++ b/tcg/mips/tcg-target.c.inc
@@ -1105,9 +1105,19 @@ static void tcg_out_movcond(TCGContext *s, TCGCond cond,
TCGReg ret,
static void tcg_out_call_int(TCGContext *s, const tcg_insn_unit *arg, bool
tail)
{
- /* Note that the ABI requires the called function's address to be
- loaded into T9, even if a direct branch is in range. */
- tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_T9, (uintptr_t)arg);
+ /*
+ * Note that __mips_abicalls requires the called function's address
+ * to be loaded into $25 (t9), even if a direct branch is in range.
+ *
+ * For n64, always drop the pointer into the constant pool.
+ * We can re-use helper addresses often and do not want any
+ * of the longer sequences tcg_out_movi may try.
+ */
+ if (sizeof(uintptr_t) == 8) {
+ tcg_out_movi_pool(s, TCG_REG_T9, (uintptr_t)arg, TCG_REG_TB);
+ } else {
+ tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_T9, (uintptr_t)arg);
+ }
/* But do try a direct branch, allowing the cpu better insn prefetch. */
if (tail) {
--
2.34.1
- [PATCH for-8.1 00/12] tcg/mips: Backend improvements, Richard Henderson, 2023/04/07
- [PATCH 02/12] tcg/mips: Move TCG_GUEST_BASE_REG to S7, Richard Henderson, 2023/04/07
- [PATCH 01/12] tcg/mips: Move TCG_AREG0 to S8, Richard Henderson, 2023/04/07
- [PATCH 03/12] tcg/mips: Unify TCG_GUEST_BASE_REG tests, Richard Henderson, 2023/04/07
- [PATCH 05/12] tcg/mips: Split out tcg_out_movi_one, Richard Henderson, 2023/04/07
- [PATCH 09/12] tcg/mips: Try tb-relative addresses in tcg_out_movi, Richard Henderson, 2023/04/07
- [PATCH 10/12] tcg/mips: Try three insns with shift and add in tcg_out_movi, Richard Henderson, 2023/04/07
- [PATCH 08/12] tcg/mips: Aggressively use the constant pool for n64 calls,
Richard Henderson <=
- [PATCH 07/12] tcg/mips: Use the constant pool for 64-bit constants, Richard Henderson, 2023/04/07
- [PATCH 12/12] tcg/mips: Replace MIPS_BE with HOST_BIG_ENDIAN, Richard Henderson, 2023/04/07
- [PATCH 11/12] tcg/mips: Use qemu_build_not_reached for LO/HI_OFF, Richard Henderson, 2023/04/07
- [PATCH 04/12] tcg/mips: Create and use TCG_REG_TB, Richard Henderson, 2023/04/07
- [PATCH 06/12] tcg/mips: Split out tcg_out_movi_two, Richard Henderson, 2023/04/07