|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [PATCH v3 1/5] dump: Include missing "cpu.h" header for tswap32/tswap64() declarations |
| Date: | Thu, 23 Feb 2023 23:29:05 +0100 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 23/2/23 22:43, Richard Henderson wrote:
On 2/23/23 11:19, Philippe Mathieu-Daudé wrote:This file uses tswap() 4 times in the same function: get_note_sizes(), so I could extract it to a dump-target.c unit. I have no clue what that file is for, but this particularity is odd.All uses of tswap in that file are wrong, and should be using cpu_to_dumpN, which correctly tests the endianness of the output.
Yes! Thank you :)
| [Prev in Thread] | Current Thread | [Next in Thread] |