Re: [PATCH v3 1/5] dump: Include missing "cpu.h" header for tswap32/tswap64() declarations

[Philippe Mathieu-Daudé]

On 17/12/22 00:58, Richard Henderson wrote:
> On 12/16/22 13:55, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   dump/dump.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/dump/dump.c b/dump/dump.c
> > index 279b07f09b..c62dc94213 100644
> > --- a/dump/dump.c
> > +++ b/dump/dump.c
> > @@ -29,6 +29,7 @@
> >   #include "qemu/main-loop.h"
> >   #include "hw/misc/vmcoreinfo.h"
> >   #include "migration/blocker.h"
> > +#include "cpu.h"
>
> Does it work to include "exec/cpu-all.h" instead?

We get:

include/exec/cpu-all.h:110:5: warning: 'TARGET_LONG_SIZE' is not 
defined, evaluates to 0 [-Wundef]
#if TARGET_LONG_SIZE == 4
    ^

TARGET_LONG_SIZE is defined in "exec/cpu-defs.h" which is
target specific. If I add "exec/cpu-defs.h" to "exec/cpu-all.h"
I get:

In file included from ../../dump/dump.c:18:
include/exec/cpu-all.h:439:8: error: incomplete definition of type 
'struct ArchCPU'
    cpu->parent_obj.env_ptr = &cpu->env;
    ~~~^

Is it worth extracting the few tswapX() declarations to "exec/tswap.h"?