Re: [PATCH v3 1/5] dump: Include missing "cpu.h" header for tswap32/tswap64() declarations

[Richard Henderson]

On 2/23/23 11:19, Philippe Mathieu-Daudé wrote:
> This file uses tswap() 4 times in the same function: get_note_sizes(),
> so I could extract it to a dump-target.c unit.
> I have no clue what that file is for, but this particularity is odd.

All uses of tswap in that file are wrong, and should be using cpu_to_dumpN, which 
correctly tests the endianness of the output.


r~