qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 01/19] target/arm: Make cpu_exclusive_high hold the high b


From: Richard Henderson
Subject: Re: [PATCH v1 01/19] target/arm: Make cpu_exclusive_high hold the high bits
Date: Thu, 23 Feb 2023 06:12:53 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/23/23 05:14, Peter Maydell wrote:
On Thu, 16 Feb 2023 at 03:09, Richard Henderson
<richard.henderson@linaro.org> wrote:

We currently treat cpu_exclusive_high as containing the
second word of LDXP, even though that word is not "high"
in big-endian mode.  Swap things around so that it is.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/translate-a64.c | 54 ++++++++++++++++++++------------------
  1 file changed, 29 insertions(+), 25 deletions(-)

This code change looks OK as far as it goes, but the bad
news is that we migrate the env.exclusive_val and
env.exclusive_high values in the machine state. So a
migration from a QEMU before this change to a QEMU with
this change on a BE host will get confused...

Oof. Ok, I didn't *really* need this, it just seemed to make sense. I'll add some commentary about "high" only meaning "high" for little-endian...


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]