Re: [PATCH v2 09/12] bsd-user: Start translation of arch-specific sysctls

[Warner Losh]

On Tue, Feb 14, 2023 at 2:36 PM Richard Henderson <richard.henderson@linaro.org> wrote:

On 2/13/23 14:27, Warner Losh wrote:
> +        case HW_NCPU:
> +            if (oldlen) {
> +                (*(int32_t *)holdp) = tswap32(bsd_get_ncpu());
> +            }
> +            holdlen = sizeof(int32_t);
> +            ret = 0;
> +            goto out;

Anything using SYSCTL_INT should use abi_int.

> +#if defined(TARGET_ARM)
> +        case HW_FLOATINGPT:
> +            if (oldlen) {
> +                ARMCPU *cpu = env_archcpu(env);
> +                *(abi_int *)holdp = cpu_isar_feature(aa32_vfp, cpu);
> +            }
> +            holdlen = sizeof(int32_t);

abi_int for consistency.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Makes sense.. Thanks!

Warner