qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/12] bsd-user: Add -strict


From: Richard Henderson
Subject: Re: [PATCH v2 12/12] bsd-user: Add -strict
Date: Tue, 14 Feb 2023 11:49:18 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/13/23 14:27, Warner Losh wrote:
Most of the time, it's useful to make our best effort, but sometimes we
want to know right away when we don't implement something. First place
we use it is for unknown syscalls.

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
  bsd-user/freebsd/os-syscall.c | 4 ++++
  bsd-user/main.c               | 5 ++++-
  bsd-user/qemu.h               | 1 +
  3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 179a20c304b..e2b26ecb8dd 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -508,6 +508,10 @@ static abi_long freebsd_syscall(void *cpu_env, int num, 
abi_long arg1,
default:
          qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
+        if (bsd_user_strict) {
+            printf("Unimplemented system call %d\n", num);
+            abort();
+        }

Still don't like the printf.  I suggested alternatives against v1.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]