qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/12] bsd-user: Add -strict


From: Warner Losh
Subject: Re: [PATCH v2 12/12] bsd-user: Add -strict
Date: Thu, 16 Feb 2023 15:37:40 -0700



On Tue, Feb 14, 2023 at 2:49 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 2/13/23 14:27, Warner Losh wrote:
> Most of the time, it's useful to make our best effort, but sometimes we
> want to know right away when we don't implement something. First place
> we use it is for unknown syscalls.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/freebsd/os-syscall.c | 4 ++++
>   bsd-user/main.c               | 5 ++++-
>   bsd-user/qemu.h               | 1 +
>   3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
> index 179a20c304b..e2b26ecb8dd 100644
> --- a/bsd-user/freebsd/os-syscall.c
> +++ b/bsd-user/freebsd/os-syscall.c
> @@ -508,6 +508,10 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
>   
>       default:
>           qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
> +        if (bsd_user_strict) {
> +            printf("Unimplemented system call %d\n", num);
> +            abort();
> +        }

Still don't like the printf.  I suggested alternatives against v1.

Yea, this was unchanged in this version since there were too many other things to do in the other bits that went into v2.

I'm thinking, though, that this isn't ready, so I'm going to drop it from v3.

Warner 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]