Re: [PATCH v2 10/12] bsd-user: do_freebsd_sysctl helper for sysctl(2)

[Richard Henderson]

On 2/13/23 14:27, Warner Losh wrote:
> +    int32_t *snamep = g_malloc(sizeof(int32_t) * namelen), *p, *q, i;

g_new(int32_t, namelen)

> +    unlock_user(holdp, oldp, holdlen);
> +    unlock_user(holdp, oldp, ret == 0 ? holdlen : 0);

double-unlock.  clearly the first line is extra.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~