[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] target/arm: Handle trapping to EL2 of AArch32 VMRS in
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 3/5] target/arm: Handle trapping to EL2 of AArch32 VMRS instructions |
|
Date: |
Fri, 6 Dec 2019 09:45:55 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 |
On 12/6/19 6:08 AM, Peter Maydell wrote:
>> DEF_HELPER_FLAGS_3(autdb, TCG_CALL_NO_WG, i64, env, i64, i64)
>> DEF_HELPER_FLAGS_2(xpaci, TCG_CALL_NO_RWG_SE, i64, env, i64)
>> DEF_HELPER_FLAGS_2(xpacd, TCG_CALL_NO_RWG_SE, i64, env, i64)
>> +
>> +DEF_HELPER_3(check_hcr_el2_trap, void, env, i32, i32)
>
> This has to be in helper.h, not helper-a64.h, otherwise
> the arm-softmmu target won't build. helper-a64.h is for
> helper functions which only exist in the aarch64 binary.
Oh, while we're at it,
DEF_HELPER_FLAGS_3(..., TCG_CALL_NO_WG, ...)
The helper does not modify tcg globals (on successful return).
It does read globals (via the exception path), and of course it has side
effects (the exception).
r~
[PATCH v2 2/5] target/arm: Honor HCR_EL2.TID1 trapping requirements, Marc Zyngier, 2019/12/01
[PATCH v2 4/5] target/arm: Handle AArch32 CP15 trapping via HSTR_EL2, Marc Zyngier, 2019/12/01
Re: [PATCH v2 0/5] target/arm: More EL2 trapping fixes, Peter Maydell, 2019/12/06