|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 4/5] target/arm: Handle AArch32 CP15 trapping via HSTR_EL2 |
Date: | Mon, 2 Dec 2019 07:52:36 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 |
On 12/1/19 12:20 PM, Marc Zyngier wrote: > + /* Check for an EL2 trap due to HSTR_EL2. We expect EL0 accesses > + * to sysregs non accessible at EL0 to have UNDEF-ed already. > + */ We're enforcing /* * Multi-line comment */ for qemu now; checkpatch should be reporting on that. > + if (!env->aarch64 && arm_current_el(env) < 2 && ri->cp == 15 && > + (arm_hcr_el2_eff(env) & (HCR_E2H | HCR_TGE)) != (HCR_E2H | HCR_TGE)) > { Use is_a64(env) not env->aarch64 directly. Otherwise, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |