[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 06/21] qdev-monitor: well form error hint helpers

From: Eric Blake
Subject: Re: [PATCH v8 06/21] qdev-monitor: well form error hint helpers
Date: Thu, 5 Dec 2019 12:18:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/5/19 12:17 PM, Eric Blake wrote:
On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote:
Make qbus_list_bus and qbus_list_dev hint append helpers well formed:
switch errp paramter to Error *const * type, as it has uncommon
behavior: not change the pointer to return error, but operate on
already existent error object.
Rename functions to be error_append_*_hint.


Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  qdev-monitor.c | 12 +++++++-----
  1 file changed, 7 insertions(+), 5 deletions(-)

-static void qbus_list_dev(BusState *bus, Error **errp)
+static void qbus_error_append_dev_list_hint(BusState *bus,
+                                            Error *const *errp)

Or, since you copy-and-paste this commit message in v9, you could use

Sorry, I meant it was copied in v8 7/21.

*_error_append_*_hint between the commits for less one-off fixing per message.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]