[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channe

From: Vladimir Sementsov-Ogievskiy
Subject: [PATCH v8 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error
Date: Thu, 5 Dec 2019 20:46:35 +0300

The local_err parameter is not here to return information about
nbd_iter_channel_error failure. Instead it's assumed to be filled when
passed to the function. This is already stressed by its name
(local_err, instead of classic errp). Stress it additionally by

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
 block/nbd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/nbd.c b/block/nbd.c
index 5f18f78a94..d085554f21 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -866,6 +866,7 @@ typedef struct NBDReplyChunkIter {
 static void nbd_iter_channel_error(NBDReplyChunkIter *iter,
                                    int ret, Error **local_err)
+    assert(local_err && *local_err);
     assert(ret < 0);
     if (!iter->ret) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]