[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common er
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp |
|
Date: |
Fri, 6 Dec 2019 10:19:55 +0000 |
06.12.2019 10:38, Philippe Mathieu-Daudé wrote:
> On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> hw/usb/dev-network.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
>> index 5de6213cc4..b81a8abe83 100644
>> --- a/hw/usb/dev-network.c
>> +++ b/hw/usb/dev-network.c
>> @@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
>> .cleanup = usbnet_cleanup,
>> };
>> -static void usb_net_realize(USBDevice *dev, Error **errrp)
>
> Funny one.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
Thanks a lot for reviewing!
--
Best regards,
Vladimir
- [PATCH v8 02/21] net/net: Clean up variable shadowing in net_client_init(), (continued)
- [PATCH v8 02/21] net/net: Clean up variable shadowing in net_client_init(), Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 13/21] monitor/qmp-cmds: rename Error ** parameter to more common errp, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 08/21] 9pfs: well form error hint helpers, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 15/21] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 10/21] block/snapshot: rename Error ** parameter to more common errp, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 17/21] hw/usb: rename Error ** parameter to more common errp, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 05/21] vnc: drop Error pointer indirection in vnc_client_io_error, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 09/21] hw/core/qdev: cleanup Error ** variables, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 06/21] qdev-monitor: well form error hint helpers, Vladimir Sementsov-Ogievskiy, 2019/12/05
- [PATCH v8 18/21] include/qom/object.h: rename Error ** parameter to more common errp, Vladimir Sementsov-Ogievskiy, 2019/12/05