Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers

[Michael S. Tsirkin]

On Tue, May 08, 2018 at 02:25:07PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > This way they are easier to find using standard rules.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> Nack.
> 
> This are _internal_ files, that shouldn't be used anywere elese.
> 
> Except .... that we need them to write tests.  We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
> 
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
> I *think* that using complete paths is the only reasonable way of doing
> this.
> 
> Thanks, Juan.

So how about tests include internal headers in a special way then?

#include "../migration/foo.h" works but makes it clear
something unusual is going on.