Re: [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers

[Michael S. Tsirkin]

On Fri, May 04, 2018 at 10:15:56AM +1000, David Gibson wrote:
> On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> > This way they are easier to find using standard rules.
> > 
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> I don't really understand what this is accomplishing.

Pls see the cover letter.

The specific headers are used outside their directory so ideally long
term either they should move to include or split or callers refactored.

It's up to maintainers to decide what to do, I do not want to make this
decision.

> > ---
> >  include/hw/ppc/e500-ccsr.h | 1 +
> >  include/hw/ppc/mac.h       | 1 +
> >  2 files changed, 2 insertions(+)
> >  create mode 100644 include/hw/ppc/e500-ccsr.h
> >  create mode 100644 include/hw/ppc/mac.h
> > 
> > diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> > new file mode 100644
> > index 0000000..08e4ba2
> > --- /dev/null
> > +++ b/include/hw/ppc/e500-ccsr.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/e500-ccsr.h"
> > diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> > new file mode 100644
> > index 0000000..e0f0b67
> > --- /dev/null
> > +++ b/include/hw/ppc/mac.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/mac.h"
> 
> -- 
> David Gibson                  | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au        | minimalist, thank you.  NOT _the_ 
> _other_
>                               | _way_ _around_!
> http://www.ozlabs.org/~dgibson