[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers |
Date: |
Tue, 08 May 2018 14:25:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
Nack.
This are _internal_ files, that shouldn't be used anywere elese.
Except .... that we need them to write tests. We only have two scopes
on qemu:
- internal: only for the subsystem we are at in
- pubilc: they can be used everywhere
So, tests came in a strange class here, because they need internal
implementation, but they are not in the proper directory due to the way
we do tests.
I *think* that using complete paths is the only reasonable way of doing
this.
Thanks, Juan.
- [Qemu-devel] [PATCH 22/67] ui: use local path for local headers, (continued)
- [Qemu-devel] [PATCH 22/67] ui: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 25/67] arch_init: sort architectures, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 28/67] 9pfs: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 30/67] audio: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 33/67] hw/net: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 32/67] ui: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 36/67] migration: add include directory headers, Michael S. Tsirkin, 2018/05/03
- Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers,
Juan Quintela <=
- [Qemu-devel] [PATCH 37/67] tcg: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers, Michael S. Tsirkin, 2018/05/03