Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers

[Philippe Mathieu-Daudé]

On 05/08/2018 09:25 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> Nack.
> 
> This are _internal_ files, that shouldn't be used anywere elese.
> 
> Except .... that we need them to write tests.  We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
> 
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
> 
> I *think* that using complete paths is the only reasonable way of doing
> this.

I hit the same issue with SD tests.

The current scheme is confuse but works fine:

tests/test-vmstate.c:30:#include "migration/qemu-file-types.h"
tests/test-vmstate.c:32:#include "../migration/qemu-file-channel.h"

Michael, what about keeping those includes internal ("only for the
subsystem we are at in") and adding complete paths in
tests/Makefile.include?
Such:

tests/test-vmstate.o: QEMU_CFLAGS += -I$(SRC_PATH)/migration