[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
Date: Tue, 8 May 2018 09:56:43 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/08/2018 09:25 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
>> This way they are easier to find using standard rules.
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Nack.
> This are _internal_ files, that shouldn't be used anywere elese.
> Except .... that we need them to write tests.  We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
> I *think* that using complete paths is the only reasonable way of doing
> this.

I hit the same issue with SD tests.

The current scheme is confuse but works fine:

tests/test-vmstate.c:30:#include "migration/qemu-file-types.h"
tests/test-vmstate.c:32:#include "../migration/qemu-file-channel.h"

Michael, what about keeping those includes internal ("only for the
subsystem we are at in") and adding complete paths in

tests/test-vmstate.o: QEMU_CFLAGS += -I$(SRC_PATH)/migration

reply via email to

[Prev in Thread] Current Thread [Next in Thread]