Re: [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type

[Cao jin]

On 06/06/2016 04:27 PM, Hannes Reinecke wrote:
> On 06/06/2016 10:00 AM, Cao jin wrote:

> > @@ -2422,10 +2420,8 @@ static Property megasas_properties_gen1[] = {
> >                          MEGASAS_DEFAULT_FRAMES),
> >       DEFINE_PROP_STRING("hba_serial", MegasasState, hba_serial),
> >       DEFINE_PROP_UINT64("sas_address", MegasasState, sas_addr, 0),
> > -    DEFINE_PROP_BIT("use_msi", MegasasState, flags,
> > -                    MEGASAS_FLAG_USE_MSI, false),
> > -    DEFINE_PROP_BIT("use_msix", MegasasState, flags,
> > -                    MEGASAS_FLAG_USE_MSIX, false),
> > +    DEFINE_PROP_ON_OFF_AUTO("msi", MegasasState, msi, ON_OFF_AUTO_AUTO),
> > +    DEFINE_PROP_ON_OFF_AUTO("msix", MegasasState, msix, ON_OFF_AUTO_AUTO),
> >       DEFINE_PROP_BIT("use_jbod", MegasasState, flags,
> >                       MEGASAS_FLAG_USE_JBOD, false),
> >       DEFINE_PROP_END_OF_LIST(),
> > @@ -2438,10 +2434,8 @@ static Property megasas_properties_gen2[] = {
> >                          MEGASAS_GEN2_DEFAULT_FRAMES),
> >       DEFINE_PROP_STRING("hba_serial", MegasasState, hba_serial),
> >       DEFINE_PROP_UINT64("sas_address", MegasasState, sas_addr, 0),
> > -    DEFINE_PROP_BIT("use_msi", MegasasState, flags,
> > -                    MEGASAS_FLAG_USE_MSI, true),
> > -    DEFINE_PROP_BIT("use_msix", MegasasState, flags,
> > -                    MEGASAS_FLAG_USE_MSIX, true),
> > +    DEFINE_PROP_ON_OFF_AUTO("msi", MegasasState, msi, ON_OFF_AUTO_AUTO),
> > +    DEFINE_PROP_ON_OFF_AUTO("msix", MegasasState, msix, ON_OFF_AUTO_AUTO),
> >       DEFINE_PROP_BIT("use_jbod", MegasasState, flags,
> >                       MEGASAS_FLAG_USE_JBOD, false),
> >       DEFINE_PROP_END_OF_LIST(),
> What is the default value of 'ON_OFF_AUTO_AUTO'?
> Originally we've disabled MSI-X for gen1, and enabled it for gen2.
> Is this behaviour carried over?

default value of auto is on. Seems the behaviour is not carried over. If 
it must be carried over, gen1 will be the only one exception in all 
devices, which seems little weird. is any special reason for gen1 to be 
msi/msix-incapable by default?

> Cheers,
>
> Hannes

--
Yours Sincerely,

Cao jin