Re: [Qemu-devel] [PULL 10/28] migration: add reporting of errors for outgoing migration

[Paolo Bonzini]

On 26/05/2016 08:12, Amit Shah wrote:
> @@ -863,12 +867,15 @@ static void migrate_fd_cleanup(void *opaque)
>      notifier_list_notify(&migration_state_notifiers, s);
>  }
>  
> -void migrate_fd_error(MigrationState *s)
> +void migrate_fd_error(MigrationState *s, const Error *error)
>  {
> -    trace_migrate_fd_error();
> +    trace_migrate_fd_error(error ? error_get_pretty(error) : "");

This check on error == NULL is unnecessary, the only caller passes a
non-NULL error.

Paolo