[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/7] vnc: Add support for color map
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 5/7] vnc: Add support for color map |
Date: |
Mon, 6 Jun 2016 10:35:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 03/06/2016 09:04, Gerd Hoffmann wrote:
> static void set_pixel_format(VncState *vs,
> int bits_per_pixel, int depth,
> int big_endian_flag, int true_color_flag,
> @@ -2101,8 +2119,15 @@ static void set_pixel_format(VncState *vs,
> int red_shift, int green_shift, int blue_shift)
> {
> if (!true_color_flag) {
> - vnc_client_error(vs);
> - return;
> + /* Expose a reasonable default 256 color map */
> + bits_per_pixel = 8;
> + depth = 8;
> + red_max = 7;
> + green_max = 7;
> + blue_max = 3;
> + red_shift = 0;
> + green_shift = 3;
> + blue_shift = 6;
> }
Coverity now notes that the "depth" argument is unused.
It's not introduced by this patch, but now it notices because this hunk
introduces a dead write.
Thanks,
Paolo
- [Qemu-devel] [PULL 0/7] ui patch queue, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 3/7] gtk: fix unchecked vc dereference, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 5/7] vnc: Add support for color map, Gerd Hoffmann, 2016/06/03
- Re: [Qemu-devel] [PULL 5/7] vnc: Add support for color map,
Paolo Bonzini <=
- [Qemu-devel] [PULL 4/7] SDL2: add bgrx pixel format, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 6/7] sdl2: skip init without outputs, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 1/7] ui: egl: Replace fprintf with error_report, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 7/7] vnc: add configurable keyboard delay, Gerd Hoffmann, 2016/06/03
- [Qemu-devel] [PULL 2/7] ui: spice: Exit if gl=on EGL init fails, Gerd Hoffmann, 2016/06/03
- Re: [Qemu-devel] [PULL 0/7] ui patch queue, Peter Maydell, 2016/06/03