[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_us
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi() |
Date: |
Mon, 6 Jun 2016 10:31:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 06/06/2016 10:01 AM, Cao jin wrote:
> megasas overwrite user configuration when msi_init fail to reflect internal
> msi
> state, which is unsuitable. megasa_use_msi() is unnecessary, we can call
> msi_uninit() when unrealize, even no bother to call msi_enabled() first.
>
> cc: Hannes Reinecke <address@hidden>
> cc: Paolo Bonzini <address@hidden>
> cc: Markus Armbruster <address@hidden>
> cc: Marcel Apfelbaum <address@hidden>
> cc: Michael S. Tsirkin <address@hidden>
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/scsi/megasas.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
Acked-by: Hannes Reinecke <address@hidden>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
address@hidden +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH v7 07/15] intel-hda: change msi property type, (continued)
- [Qemu-devel] [PATCH v7 07/15] intel-hda: change msi property type, Cao jin, 2016/06/06
- [Qemu-devel] [PATCH v7 05/15] mptsas: change .realize function name, Cao jin, 2016/06/06
- [Qemu-devel] [PATCH v7 15/15] vmw_pvscsi: remove unnecessary internal msi state flag, Cao jin, 2016/06/06
- [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it, Cao jin, 2016/06/06
- [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi(), Cao jin, 2016/06/06
- Re: [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi(),
Hannes Reinecke <=
- [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success, Cao jin, 2016/06/06
- [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type, Cao jin, 2016/06/06
- Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init(), Cao jin, 2016/06/08
- Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init(), Markus Armbruster, 2016/06/09