[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Restore consistent formatting
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Restore consistent formatting |
Date: |
Thu, 09 Feb 2012 10:48:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Anthony Liguori <address@hidden> writes:
> On 02/08/2012 09:04 AM, malc wrote:
>> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>>
>>> malc,
>>>
>>> Arbitrarily reformatting your files is not okay. If you want a different
>>> formatting, you need to fix checkpatch.pl first to not error on that
>>> formatting in your files.
>>
>> It was always formatter like this (internally consistent), then others
>> added code which made it not so.
>
> We do have a mixed style in the audio layer. I'm not happy about that
> but I also feel strongly that going through and doing a reformat is
> not a worthwhile exercise.
>
> I can also understand the desire to keep things consistent. But
> patches should always go to the mailing list. I certainly would have
> acked such a patch FWIW.
You buried the one truly important sentence, let me dig it out for you:
*** Patches should always go to the mailing list ***
Exceptions need justification. Responsible handling embargoed security
issues may qualify. Style fixes certainly not.
[...]
- [Qemu-devel] Restore consistent formatting, Evgeny Voevodin, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, malc, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Blue Swirl, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting,
Markus Armbruster <=
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/09
- Re: [Qemu-devel] Restore consistent formatting, Blue Swirl, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/08