[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Restore consistent formatting
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] Restore consistent formatting |
Date: |
Wed, 08 Feb 2012 13:41:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
malc,
Arbitrarily reformatting your files is not okay. If you want a different
formatting, you need to fix checkpatch.pl first to not error on that
formatting in your files.
And please post your patches to the mailing list.
Thanks,
Andreas
Am 08.02.2012 11:11, schrieb Evgeny Voevodin:
> The last commit "Restore consistent formatting"
> (cf4dc461a4cfc3e056ee24edb26154f4d34a6278) which is on the master but
> absent in mailing list results in such output of checkpatch.pl:
>
> ./scripts/checkpatch.pl --no-tree --file hw/cs4231a.c
> ...
> total: 107 errors, 88 warnings, 696 lines checked
>
> -----------------------------------------------------------------
>
> ./scripts/checkpatch.pl --no-tree --file hw/adlib.c
> ...
> total: 7 errors, 58 warnings, 337 lines checked
>
> -----------------------------------------------------------------
>
> ./scripts/checkpatch.pl --no-tree --file hw/ac97.c
> ...
> total: 16 errors, 324 warnings, 1380 lines checked
>
>
> and so on.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] Restore consistent formatting, Evgeny Voevodin, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting,
Andreas Färber <=
- Re: [Qemu-devel] Restore consistent formatting, malc, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/08
- Re: [Qemu-devel] Restore consistent formatting, Blue Swirl, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting, Markus Armbruster, 2012/02/09
- Re: [Qemu-devel] Restore consistent formatting, Anthony Liguori, 2012/02/09
- Re: [Qemu-devel] Restore consistent formatting, Blue Swirl, 2012/02/11
- Re: [Qemu-devel] Restore consistent formatting, Andreas Färber, 2012/02/08