[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce memory_region_init
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation |
Date: |
Sun, 04 Dec 2011 14:24:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-12-04 14:20, Avi Kivity wrote:
> On 12/03/2011 01:17 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> Introduce a memory region type that can reserve I/O space. Such regions
>> are useful for modeling I/O that is only handled outside of QEMU, i.e.
>> in the context of an accelerator like KVM. Any access to such a region
>> from QEMU is a bug and will be reported as such.
>
> This is guest triggerable (DMA into the region), so abort() is too drastic.
Mmh, true. Will turn it into a print-once warning.
>
>> +void memory_region_init_reservation(MemoryRegion *mr,
>> + const char *name,
>> + uint64_t size)
>> +{
>> + memory_region_init(mr, name, size);
>> + mr->ops = &reservation_ops;
>> + mr->opaque = mr;
>> + mr->terminates = true;
>> + mr->backend_registered = false;
>> +}
>
> Just calling memory_region_init_io() is simpler, no?
Yep.
Thanks,
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [RFC][PATCH 08/16] ioapic: Reject non-dword accesses to IOWIN register, Jan Kiszka, 2011/12/03
[Qemu-devel] [RFC][PATCH 11/16] kvm: Introduce core services for in-kernel irqchip support, Jan Kiszka, 2011/12/03