[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to ms

From: Jan Kiszka
Subject: Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported
Date: Sun, 04 Dec 2011 14:16:07 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv: Gecko/20080226 SUSE/ Thunderbird/ Mnenhy/

On 2011-12-04 14:12, Avi Kivity wrote:
> On 12/03/2011 01:17 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>> Rename msix_supported to msi_supported and control MSI and MSI-X
>> activation this way. That was likely to original intention for this
>> flag, but MSI support came after MSI-X.
> 'and' is a dangerous word in a changelog entry.

This patch hardly qualifies for two IMHO.

>> +
>> +    if (!msi_supported) {
>> +        return -ENOTSUP;
>> +    }
>> +
> This changes behaviour.  qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will
> be different after this, no?

Only isapc had msix_supported = 0, and I doubt we got there (msi_init)
for that machine. Or am I missing something?


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]