[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to ms

From: Avi Kivity
Subject: Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported
Date: Sun, 04 Dec 2011 15:12:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
> Rename msix_supported to msi_supported and control MSI and MSI-X
> activation this way. That was likely to original intention for this
> flag, but MSI support came after MSI-X.

'and' is a dangerous word in a changelog entry.

> +
> +    if (!msi_supported) {
> +        return -ENOTSUP;
> +    }
> +

This changes behaviour.  qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will
be different after this, no?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]