[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce memory_region_init

From: Avi Kivity
Subject: Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation
Date: Sun, 04 Dec 2011 15:20:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
> Introduce a memory region type that can reserve I/O space. Such regions
> are useful for modeling I/O that is only handled outside of QEMU, i.e.
> in the context of an accelerator like KVM. Any access to such a region
> from QEMU is a bug and will be reported as such.

This is guest triggerable (DMA into the region), so abort() is too drastic.

> +void memory_region_init_reservation(MemoryRegion *mr,
> +                                    const char *name,
> +                                    uint64_t size)
> +{
> +    memory_region_init(mr, name, size);
> +    mr->ops = &reservation_ops;
> +    mr->opaque = mr;
> +    mr->terminates = true;
> +    mr->backend_registered = false;
> +}

Just calling memory_region_init_io() is simpler, no?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]