AW: Re: Re: BuildBots no longer run make check?

[markus.muetzel]

> jwe wrote:
> > Note that I'm not an expert in python or buildbot. Any suggestions and
> > improvements are welcome, especially for filtering the log files to
> > properly report success/failure for the tests with buildbot version 1.x.
> 
> 
> I really don't know whether I understand what is going on.
> But might this change help?:
> 
> diff -r 4ad92f00bca5 master.cfg
> --- a/master.cfg      Tue Jun 05 12:38:50 2018 +0000
> +++ b/master.cfg      Tue Jun 05 22:04:40 2018 +0200
> @@ -272,7 +272,7 @@
>      ## FIXME: should probably search for the "^Summary:$" line just
>      ## before the PASS/FAIL totals.
> 
> -    logtext = "".join(self.getLog('stdio').readlines())
> +    logtext = "\n".join(self.getLog('stdio').readlines())
> 
>      m = re.search (r"^ *FAIL +([0-9]+) *$", logtext,
>                     flags = re.MULTILINE)

After digging a little deeper in the buildbot docs, I assume that 
self.getLog('stdio') returns a buildbot.process.log.Log object.
These objects don't seem to have a readlines method. In fact the documentation 
states [1]:
"This class handles write-only access to log files from running build steps. It 
does not provide an interface for reading logs - such access should occur 
directly through the Data API."

Maybe adding a buildbot.process.logobserver.BufferLogObserver and using its 
getStdout would do what is needed. [2]
Or we could use a LogObserver and wait for the FAIL or REGRESSION line and set 
a property that can be used in the evaluateCommand function. Somewhat similar 
to [3].

Unfortunately, I don't have a buildbot test setup and I'm by far not 
comfortable enough in Python to write some code without testing. I hope this 
might be helpful anyways.

Markus

[1]: http://docs.buildbot.net/current/developer/cls-log.html
[2]: 
http://docs.buildbot.net/current/developer/cls-logobserver.html#buildbot.process.logobserver.BufferLogObserver
 
[3]: 
http://docs.buildbot.net/latest/manual/customization.html#adding-logobservers