[Octave-bug-tracker] [bug #60016] libqhull was deprecated in favor of libqhull_r

[Rik]

Follow-up Comment #27, bug #60016 (project octave):

I agree--no special autoconf macros for unique cases.

I think your small patch which renames QHULL_R_XXX flags to QHULL_XXX flags is
a reasonable compromise.

However, I'm also now leaning towards just changing the flag names to
QHULL_R_XXX.  Octave now requires the re-entrant version of the library,
correct?

I previously used the example of BLAS_LIBS as an argument for keeping the same
flag names (QHULL_XXX) regardless of the underlying implementation.  That
makes sense for BLAS where the implementation could be reference BLAS,
OpenBLAS, ATLAS, or something else, but the API is exactly the same and there
are no code changes required.

In this case, the re-entrant QHULL library required us to change our code. 
That makes me think we should use the specific flag names that match the
library we are building against.                                              
                    

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60016>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/