[Octave-bug-tracker] [bug #60016] libqhull was deprecated in favor of libqhull_r

[Markus Mützel]

Follow-up Comment #26, bug #60016 (project octave):

I pushed a change to the configure test here:
https://hg.savannah.gnu.org/hgweb/octave/rev/162abe58aaef

With that, QHull seems to be detected correctly on macOS. Also the respective
tests in the test suite seem to run and pass on that platform now. (If we
still needed proof that the structure needs to be initialized, that's it. The
example on the QHull page might be incomplete.)


IIUC, those make variable names are generated automatically from the library
name by our OCTAVE_CHECK_LIB macro.
It'd be possible to have a specialized macro just for QHull to have make
variables that are not automatically derived from the library name. But I'm
not sure if it is worth the additional maintenance.

The instances where the old make variable names are still used should be fixed
though.
We could still keep the old names for the variables in build-env.h and
build-env.cc. See the attached patch.

IIUC, the make variable names are internal to the build system and probably
shouldn't concern users. I agree that that's different for the fields in the
`__octave_config_info__` structure.

Is this a good compromise? Or will this cause more confusion than what it will
help?
What do you think?


(file #51401)
    _______________________________________________________

Additional Item Attachment:

File name: bug60016-qhull-config-vals.patch Size:1 KB
   
<https://file.savannah.gnu.org/file/bug60016-qhull-config-vals.patch?file_id=51401>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60016>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/