Re: lynx-dev Lynx segfault while using image viewers

[Thomas Dickey]

On Thu, Jan 03, 2002 at 06:03:30AM -0500, Philip Webb wrote:
> 020103 Philip Webb wrote:
> > i'm now using 2-8-5dev.5 (the problem was with 2-8-4dev.19 ),
> > so i will report on tonight's newsreading session tomorrow morning.
> 
> using 2-8-5dev.5 , i downloaded  31  image files (mainly jpg) w/o problems.
> i also checked those still cached under /tmp with another Lynx invocation
> & got  19  image files w/o a crash, tho'  3  wouldn't display (bad images).
> 
> so for now, i'll assume there was something wrong with 2-8-4dev.19 ,
> which has been fixed in subsequent development.

yes, that's what I did say...

Here's a fix for the problem with dev.6 123g stuff

--- lynx2.8.5dev.6+/src/LYGetFile.c     Tue Jan  1 20:55:54 2002
+++ lynx2.8.5dev.6a/src/LYGetFile.c     Thu Jan  3 17:57:10 2002
@@ -1250,7 +1250,7 @@
     */
    if (*num > 0) {
        int info;
-       char *text;
+       char *text = NULL;
 
        /*
         *  Get the lname, and hightext, directly from www
@@ -1268,7 +1268,8 @@
                             &new_link,
                             &text,
                             &links[cur].lname);
-       LYSetHilite(cur, text);
+       if (text != NULL)
+           LYSetHilite(cur, text);
        if (info == WWW_INTERN_LINK_TYPE) {
            links[cur].type = WWW_INTERN_LINK_TYPE;
            return(DO_LINK_STUFF);

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden