|
From: | Fabrizio Carrai |
Subject: | Re: [Linphone-developers] [Bug] Call pausing |
Date: | Wed, 26 Aug 2015 00:19:39 +0200 |
linphone_gtk_call_update_tab_header(call,FALSE);linphone_gtk_call_update_tab_header(call,TRUE);
Dear Fabrizio,
there is no bug there:
- when you press call on your side, the UI will change button "Pause" to "Resume"
AND change the |>(play) shaped logo in the call view to a ||(paused) shaped logo.
- when the call is paused by remote, you will just get the second change as you're not given the possibility to resume the call.
Try to implement your suggestion and you will see that the logo displaying the current call status won't be modified anymore when you pause the call.
regards
Johan
On 25/08/15 20:15, Fabrizio Carrai wrote:
Here a bug I found (another will follow), please feel free to comment.
Version:Description:Linphone 3.8.5 (Linux)
Module:The bug has been found during a code review. No test have been done yet, although the error seems to be evident.
Code:gtk/main.c
switch(cs){
static void linphone_gtk_call_state_changed(LinphoneCore *lc, LinphoneCall *call, LinphoneCallState cs, const char *msg){
[...]
case LinphoneCallPausing:
linphone_gtk_enable_hold_button(call,TRUE,FALSE);
linphone_gtk_call_update_tab_header(call,FALSE);<<<<----- 'break' is missingcase LinphoneCallPausedByRemote:
linphone_gtk_in_call_view_set_paused(call);
linphone_gtk_call_update_tab_header(call,TRUE);
break;
[...]
linphone_gtk_update_call_buttons (call);
}
--
Fabrizio
_______________________________________________ Linphone-developers mailing list address@hidden https://lists.nongnu.org/mailman/listinfo/linphone-developers
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
[Prev in Thread] | Current Thread | [Next in Thread] |