linphone-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] [Bug] Call pausing


From: Johan Pascal
Subject: Re: [Linphone-developers] [Bug] Call pausing
Date: Wed, 26 Aug 2015 03:41:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0

Hi Fabrizio,
you're right, the first call seems pretty useless to me.

johan

On 26/08/15 00:19, Fabrizio Carrai wrote:
Hi Johan,
at least I wrote that I didn't test it (and I should had to) before to report it...

But what about the sequence of
linphone_gtk_call_update_tab_header(call,FALSE);
linphone_gtk_call_update_tab_header(call,TRUE);
that results from the missing break when we have a local call pausing ?

Regards
Fabrizio


2015-08-25 22:16 GMT+02:00 Johan Pascal <address@hidden>:
Dear Fabrizio,
there is no bug there:
- when you press call on your side, the UI will change button "Pause" to "Resume"
AND change the |>(play) shaped logo in the call view to a ||(paused) shaped logo.

- when the call is paused by remote, you will just get the second change as you're not given the possibility to resume the call.

Try to implement your suggestion and you will see that the logo displaying the current call status won't be modified anymore when you pause the call.

regards

Johan



On 25/08/15 20:15, Fabrizio Carrai wrote:
Here a bug I found (another will follow), please feel free to comment.

 
Version:
Linphone 3.8.5 (Linux)

Description:
The bug has been found during a code review. No test have been done yet, although the error seems to be evident.

Module:

gtk/main.c


Code:

static void linphone_gtk_call_state_changed(LinphoneCore *lc, LinphoneCall *call, LinphoneCallState cs, const char *msg){
switch(cs){

[...]
case LinphoneCallPausing:
linphone_gtk_enable_hold_button(call,TRUE,FALSE);
linphone_gtk_call_update_tab_header(call,FALSE);
<<<<----- 'break' is missing
case LinphoneCallPausedByRemote:
linphone_gtk_in_call_view_set_paused(call);
linphone_gtk_call_update_tab_header(call,TRUE);
break;

[...]
linphone_gtk_update_call_buttons (call);
}



--
Fabrizio


_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers


_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers




--
Fabrizio


_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers


reply via email to

[Prev in Thread] Current Thread [Next in Thread]