Re: Issue 1228: 5-month-old PATCH

[James Lowe]

Hello

-----Original Message-----
From: Graham Percival <address@hidden>
Date: Sat, 22 Jan 2011 20:59:11 +0000
To: "address@hidden" <address@hidden>
Cc: James Lowe <address@hidden>, lilypond-devel
<address@hidden>
Subject: Re: Issue 1228: 5-month-old PATCH

>On Sat, Jan 22, 2011 at 01:51:26PM -0700, Carl Sorensen wrote:
>> On 1/22/11 1:32 PM, "James Lowe" <address@hidden> wrote:
>> 
>> > I was just going to add it as a *.ly file in the ly/ dir. Then was
>>going
>> > to ask how to add the \function to files in the source so that it
>>could be
>> > called.
>>
>> Well, I'm sorry that I overwhelmed you with my answer.  We could do it
>>with
>> a .ly file.
>
>As a (possibly temporary) solution -- or even just as a "first
>draft of a patch" -- how about this:
>1. add a file containing the scheme functions.  Call it
>ly/merge-functions.ly
>2. add the property definitions to ly/property-init.ly
>(the mergeRestsOn, mergeRestsOff, mergeRests stuff)
>3. add   \include merge-functions.ly   to propert-init.ly
>4. send patch for review+comment.

Added as http://codereview.appspot.com/4005046/

I did step 3 slightly differently as it seemed all the \includes were in
declarations-init.ly, I checked in there and it seemed the obvious place.

I have done a make ; make doc and had no errors.

I'll also announce the patch 'properly' on Dev



James