[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: biweekly Critical issues plea
From: |
address@hidden |
Subject: |
Re: biweekly Critical issues plea |
Date: |
Wed, 19 Jan 2011 16:31:47 -0500 |
result of git bisect for issue 1472
ee0488f3aa19e0060b6e17c46a4d88cb9d57c489 is the first bad commit
commit ee0488f3aa19e0060b6e17c46a4d88cb9d57c489
Author: Joe Neeman <address@hidden>
Date: Fri Jun 18 16:53:17 2010 +0300
Fix 1120.
Don't add vertical padding to the skylines that are used for
horizontal spacing, since it can lead to unwanted horizontal space.
:040000 040000 5ceaa73a77481f6c2cab8e3d3077f63000914642
70b6b1e231023394c4f5960d7db78e4037c8070d M lily
:040000 040000 9a0c9c2272038782295539863535c9d0b5c87a88
46574db4dc3bfe967df4451dabe6875f8e43d79c M ly
:040000 040000 6847b1d07bfd3fea2dfc35ae0a0856693da14a37
a256b66bcccb7f1f001c7e0de281a697d69e824f M scm
What next?
MS
On Jan 19, 2011, at 11:33 AM, Graham Percival wrote:
> Have you read this page recently?
> http://lilypond.org/doc/v2.13/Documentation/contributor/finding-the-cause-of-a-regression
>
> I think that the instructions are fairly clear, but if they're
> not, please let me know so that I can improve them. (if you're
> familiar with American programming jargon, then think
> "dogfooding")
>
> Also, don't forget to look for previous discussion, especially
> anything that Neil has written. I wouldn't be surprised if he
> already identified the exact commit that's the problem, and/or
> posted an experimental patch. Maybe all we need to do is to
> "unearth" that patch (from all of 4 days ago!), test it a bit,
> discuss why it works and doesn't hurt anything, then push it.
> I don't know.
>
> [NB: this talk of a patch is purely hypothetical. I haven't
> followed the discussion about this; that's your job. I'm just
> pointing out that you'll feel awfully silly if you spend 2 hours
> working on this, and then discover that somebody already posted a
> patch that works.]
>
> Cheers,
> - Graham
>
> On Wed, Jan 19, 2011 at 11:10:12AM -0500, address@hidden wrote:
>> Graham,
>>
>> In this I'm a bit over my head - I am terrible with git stuff, and will need
>> instructions & coaxing to get through this rewinding and bisecting thing.
>> Alternatively, I could just try to code something that fixes the problem.
>>
>
- biweekly Critical issues plea, Graham Percival, 2011/01/19
- Re: biweekly Critical issues plea, address@hidden, 2011/01/19
- Re: biweekly Critical issues plea, Graham Percival, 2011/01/19
- Re: biweekly Critical issues plea, Benkő Pál, 2011/01/19
- Re: biweekly Critical issues plea, Graham Percival, 2011/01/19
- Re: biweekly Critical issues plea, Benkő Pál, 2011/01/19
- Re: biweekly Critical issues plea, Francisco Vila, 2011/01/19
- Re: biweekly Critical issues plea, Graham Percival, 2011/01/19
- Re: biweekly Critical issues plea, Francisco Vila, 2011/01/19
- Message not available
- Message not available
- Re: biweekly Critical issues plea,
address@hidden <=
- Re: biweekly Critical issues plea, Graham Percival, 2011/01/19
- Re: biweekly Critical issues plea, address@hidden, 2011/01/19
- Re: biweekly Critical issues plea, Carl Sorensen, 2011/01/19
- Re: biweekly Critical issues plea, Mike Solomon, 2011/01/19
- Re: biweekly Critical issues plea, Carl Sorensen, 2011/01/19
- Re: biweekly Critical issues plea, Mike Solomon, 2011/01/19
- Re: biweekly Critical issues plea, Carl Sorensen, 2011/01/19
- Re: biweekly Critical issues plea, Carl Sorensen, 2011/01/19
- Re: biweekly Critical issues plea, Carl Sorensen, 2011/01/19
- Re: biweekly Critical issues plea, address@hidden, 2011/01/19