guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Support publishing build events


From: Clément Lassieur
Subject: Re: [PATCH 1/2] Support publishing build events
Date: Sat, 30 Nov 2019 15:23:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Christopher Baines <address@hidden> writes:

> diff --git a/src/schema.sql b/src/schema.sql
> index a9e4a6a..b84b231 100644
> --- a/src/schema.sql
> +++ b/src/schema.sql
> @@ -64,6 +64,18 @@ CREATE TABLE Builds (
>    FOREIGN KEY (evaluation) REFERENCES Evaluations (id)
>  );
>  
> +CREATE TABLE Events (
> +  id            INTEGER PRIMARY KEY,
      ^
Also, I forgot.  This row could be removed if the EventsOutbox table is
removed.

> +  type          TEXT NOT NULL,
> +  timestamp     INTEGER NOT NULL,
> +  event_json    TEXT NOT NULL
> +);
> +
> +CREATE TABLE EventsOutbox (
> +  event_id      INTEGER NOT NULL,
> +  FOREIGN KEY (event_id) REFERENCES Events (id)
> +);
> +

And now that I think about it, even if we don't remove the EventsOutbox
table, wouldn't it be simpler to just add a 'sent' column (a Boolean) to
the Events table?

Clément



reply via email to

[Prev in Thread] Current Thread [Next in Thread]