Re: [PATCH 1/2] Support publishing build events

[Christopher Baines]

Ludovic Courtès <address@hidden> writes:

> Hi Chris,
>
> Christopher Baines <address@hidden> skribis:
>
>> ---
>>  Makefile.am                 |   8 +-
>>  bin/cuirass-send-events.in  |  90 +++++++++++++++++++++++
>>  src/cuirass/base.scm        |   9 ++-
>>  src/cuirass/database.scm    | 142 +++++++++++++++++++++++++++++++++---
>>  src/cuirass/http.scm        |  24 ++++++
>>  src/cuirass/send-events.scm |  69 ++++++++++++++++++
>>  src/schema.sql              |  12 +++
>>  src/sql/upgrade-5.sql       |  15 ++++
>>  8 files changed, 356 insertions(+), 13 deletions(-)
>>  create mode 100644 bin/cuirass-send-events.in
>>  create mode 100644 src/cuirass/send-events.scm
>>  create mode 100644 src/sql/upgrade-5.sql
>
> Sorry for the delay.  It LGTM, thank you!
>
> Please add a commit log :-), and let us know when you’d like to test
> with the instance on berlin or that on bayfront.

Following up on this again, I've now sent a couple of updated
patches. Not much about the code has changed, I fixed a typo, added
better error handling to sending events, and added changelog entries to
the commit messages.

I have done more testing though, and also added more support for
receiving events to the Guix Data Service (mostly in this commit [1]).

1: 
https://git.savannah.gnu.org/cgit/guix/data-service.git/commit/?id=5663235048b7341b378634d083eaae9f13580e07

In terms of the code, the Guix Data Service is now capable of handling
Cuirass sending it events, and I've been testing this locally using the
random Cuirass example.

I'm not sure whether it's worth trying this out on bayfront prior to
merging the changes, or merging them and then trying it out on bayfront,
but either way, at the moment there's no rush, as the Guix Data Service
is down at the moment due to hardware issues.

Thanks,

Chris

signature.asc
Description: PGP signature