[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Support publishing evaluation events
From: |
Clément Lassieur |
Subject: |
Re: [PATCH 2/2] Support publishing evaluation events |
Date: |
Sat, 30 Nov 2019 15:10:13 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Christopher Baines <address@hidden> writes:
> * src/cuirass/base.scm (process-specs): Record the creation of new
> evaluations as events.
> * src/cuirass/database.scm (db-set-evaluation-done): Record when evaluations
> finish as an event.
> * src/cuirass/http.scm (url-handler): Add a new /api/evaluation-events page.
> ---
> src/cuirass/base.scm | 5 +++++
> src/cuirass/database.scm | 6 +++++-
> src/cuirass/http.scm | 9 +++++++++
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
> index e7c2597..471a15e 100644
> --- a/src/cuirass/base.scm
> +++ b/src/cuirass/base.scm
> @@ -770,6 +770,11 @@ started)."
> (checkouts (fetch-inputs spec))
> (eval-id (db-add-evaluation name checkouts)))
> (when eval-id
> + (db-add-event 'evaluation
> + (time-second (current-time time-utc))
> + `((#:evaluation . ,eval-id)
> + (#:specification . ,name)
> + (#:in_progress . #t)))
Same comment as with the other patch: I think this could go to
database.scm, so that everything is done at the same level.
Thanks,
Clément