[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow user-configurable menucolor

From: Robert Millan
Subject: Re: [PATCH] allow user-configurable menucolor
Date: Thu, 3 Jan 2008 16:35:33 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Jan 03, 2008 at 02:04:14AM +0100, Robert Millan wrote:
> > So, if you don't hesitate to create so many variables, you can simply 
> > create "normal_color", "normal_background_color", "highlight_color" 
> > and "highlight_background_color", although I don't know who would like it.
> Sounds like this could save us some code space.  I'd go for _fg and _bg to
> preserve alignment in the names.

Uhm actually, splitting those in _fg and _bg was a bit of a hassle, because GRUB
internally thinks of colors as (bg << 4 | fg) like vga does, so obtaining them
from two separate variables didn't bring any real benefit.

See attached new patch, using variable hooks.

Note: if you're going to test this using "configfile" command, think that
this opens a new context and exposes the problem with hooks I just reported
in the other thread.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

Attachment: menucolor.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]