[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] allow user-configurable menucolor

From: Robert Millan
Subject: Re: [PATCH] allow user-configurable menucolor
Date: Tue, 1 Jan 2008 14:40:26 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Jan 01, 2008 at 03:14:50PM +0200, Vesa Jääskeläinen wrote:
> First some questions ;)
> - What happens when you forgot to provide / in this string ;) ?

grub_strchr() returns NULL and... whoops!  I'll fix that :-)

> - What happens when all memory is used?

What do you mean?

> - What happens when you alter list of colors... remove one entry of it
> or add one.

This should never happen.  The list is just a human description of GRUB color
codes.  GRUB VGA-style color codes are never changed in runtime, so neither
should this list.

> (eg. hard coding is bad... sizeof...)

Where can sizeof be used?

> Now to your naming issue...
> This code is quite specific to be only local so I would propose following:
> parse_single_color_name -> parse_color_name
> parse_color_name -> parse_color_tuple, parse_color_pair,
> parse_text_color or parse_menu_color

How about `parse_color_name_pair' ?

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]