Re: [PATCH] allow user-configurable menucolor

[Robert Millan]

On Sat, Jan 05, 2008 at 10:45:46PM +0100, Jeroen Dekkers wrote:
> At Thu, 3 Jan 2008 16:35:33 +0100,
> Robert Millan wrote:
> > diff -x '*~' -x '*.mk' -Nurp grub2/include/grub/normal.h 
> > grub2.color/include/grub/normal.h
> > --- grub2/include/grub/normal.h     2007-07-22 01:32:22.000000000 +0200
> > +++ grub2.color/include/grub/normal.h       2008-01-03 16:12:53.000000000 
> > +0100
> > @@ -1,7 +1,7 @@
> >  /* normal.h - prototypes for the normal mode */
> >  /*
> >   *  GRUB  --  GRand Unified Bootloader
> > - *  Copyright (C) 2002,2003,2005,2006,2007  Free Software Foundation, Inc.
> > + *  Copyright (C) 2002,2003,2005,2006,2007,2008  Free Software Foundation, 
> > Inc.
> >   *
> >   *  GRUB is free software: you can redistribute it and/or modify
> >   *  it under the terms of the GNU General Public License as published by
> > @@ -154,6 +154,9 @@ grub_err_t grub_normal_print_device_info
> >  grub_err_t grub_normal_menu_addentry (const char *title,
> >                                   struct grub_script *script,
> >                                   const char *sourcecode);
> > +char *grub_env_write_color_normal (struct grub_env_var *var, const char 
> > *val);
> > +char *grub_env_write_color_highlight (struct grub_env_var *var, const char 
> > *val);
> > +void grub_wait_after_message (void);
> 
> You should actually also include grub/env.h if you use struct
> grub_env_var in the prototypes.

Uhm, I included it in normal/color.c to satisfy the dependencies:

normal/color.c:#include <grub/env.h>
normal/color.c:grub_env_write_color_normal (struct grub_env_var *var 
__attribute__ ((unused)),
normal/color.c:grub_env_write_color_highlight (struct grub_env_var *var 
__attribute__ ((unused)),

but your idea seems better.  I suppose we can remove it from there now?

> I've fixed that in CVS.

Thanks.

Btw, nice to see you around here.  Do you have any news about the CD-ROM
GSoC ?  I looked at the tarball from google.com, but CD access seems
unfinished (I couldn't access the CD neither in qemu nor in real hw).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)